replaceRequireScript fix for conditional html in head and for templates #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template tags If html have some conditional html or template tags in start of the file, they get messed up because of template parsing. Presently we don’t parse the html, we use regex to find script tag and then replace it.
|
That is awesome. Thank you 👯 |
asciidisco
added a commit
that referenced
this pull request
Mar 2, 2014
replaceRequireScript fix for conditional html in head and for templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaceRequireScript fix for conditional html in head and for django template tags
If html have some conditional html or template tags in start of the file, they get messed up because of template parsing.
Presently we don't parse the html, we use regex to find script tag and then replace it.